Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonky Sound #10

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Wonky Sound #10

merged 9 commits into from
Oct 7, 2024

Conversation

codingkatty
Copy link
Contributor

  • added sounds
  • moved javascript into a dedicated folder
  • added sound.js for sounds
  • html: added test link, button and input to see the effect
  • should have sound when clicking link/button and pressing keys
  • random and somehow chaotic
  • again sry if I did anything wrong, and thanks for the opportunity ^-^

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@vansh-codes vansh-codes self-requested a review October 7, 2024 12:02
Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vansh-codes vansh-codes merged commit 10031fc into vansh-codes:main Oct 7, 2024
1 check passed
@vansh-codes vansh-codes added enhancement New feature or request gssoc-ext GSSOC'24 Extd Participant level1 awards 10 points hacktoberfest hacktoberfest registered labels Oct 7, 2024
@vansh-codes
Copy link
Owner

vansh-codes commented Oct 7, 2024

From the next time:
mention the issue you have worked on by writing
Closes: #7
or if its a fix for already closed issue then write Fixes: #issueNumber

This helps the PA look into your issue and verify if you did the assigned task correctly or not and also autocloses the issue making it simpler for the PA

Keep up the chaos 😵‍💫
Happy Coding 🚀
Show you love and ⭐ the repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOC'24 Extd Participant hacktoberfest hacktoberfest registered level1 awards 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants