Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode css #41

Open
maciejmiklas opened this issue Sep 23, 2020 · 11 comments
Open

Do not hardcode css #41

maciejmiklas opened this issue Sep 23, 2020 · 11 comments

Comments

@maciejmiklas
Copy link

There is hardcoded css import:
import 'jsoneditor/dist/jsoneditor.css';

This makes any css customisation harder. Please remove this import so that we can import css of our choice.

@vaultec81
Copy link

I agree! I have found a work around that seems to work for anyone wondering. Passing CSS through htmlElementProps seems to work. But it isn't the best solution obviously.

@PunKHS
Copy link

PunKHS commented Feb 19, 2021

Maybe someone has workaround? I would like to change the .jsoneditor-menu { background-color: #4b4b4b } and cannot do it through htmlElementProps

@vaultec81
Copy link

You might be able to go into the CSS code in the node_modules folder, or change the properties of the jsoneditor-menu class through javascript if that's possible.

@SeeThruHead
Copy link

can't import any css file in node_modules in next js

@SimonKlausLudwig
Copy link

would be great, this adds a ton of css and makes lazy loading of the css really hard.

@NixBiks
Copy link

NixBiks commented May 6, 2021

@SeeThruHead I have the same issue. Found a solution?

@SeeThruHead
Copy link

no we didn't use this because of the issue

@SimonKlausLudwig
Copy link

It should be that hard to exclude the css file right ? Please take this into account..

@KirillSuhodolov
Copy link

is it possible to exclude css for next.js apps?

@anavgagneja
Copy link

@SeeThruHead did you find an alternative you liked that works with next js?

@amiram
Copy link

amiram commented Jul 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants