Feat/bump openai #159
Merged
Feat/bump openai #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
Feb 6, 2024
Comment on lines
+33
to
+45
| def init_openai_client(api_key: str) -> OpenAI: | ||
| """Initialize the OpenAI client""" | ||
| global client | ||
| if client is None: | ||
| client = OpenAI(api_key=api_key) | ||
| return client | ||
|
|
||
| def close_openai_client() -> None: | ||
| """Close the OpenAI client""" | ||
| global client | ||
| if client is not None: | ||
| client.close() | ||
| client = None |
There was a problem hiding this comment.
How about a context manager instead?
There was a problem hiding this comment.
I have another PR overlapping this, I can address there.
There was a problem hiding this comment.
@Adamantios merging this as-is. Will be addressed in an upcoming PR.
jmoreira-valory
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the openai version to
v1.11.0, due to #820.