Fix/flaky tools #138
Merged
Fix/flaky tools #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/optimization_by_prompting.py
Outdated
Comment on lines
193
to
203
| generated_template = template + instructions_format | ||
| try: | ||
| prompt = PromptTemplate( | ||
| input_variables=["user_prompt", "additional_information"], | ||
| template=generated_template, | ||
| ) | ||
| except Exception as e: | ||
| # it may happen that the generated prompt is not valid | ||
| # in that case, we just skip it | ||
| print(f"Failed to parse template {generated_template}: {e}") | ||
| continue |
There was a problem hiding this comment.
Shouldn't we change something before retrying? because it looks like the value of generated_template stays same
There was a problem hiding this comment.
I see your point, i guess it makes sense that in such instances we regenerate the template.
Adamantios
approved these changes
Nov 29, 2023
angrybayblade
approved these changes
Nov 29, 2023
Adamantios
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some flaky behaviour in the
deepmind-optimizationandprediction_request_claudetools.