Refactor execution resources to a reference #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruksi
requested changes
Sep 14, 2023
teroyks
force-pushed
the
tero/refactor/execution-resources-yaml
branch
from
ac4254b
to
c137041
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 61 61
Lines 1882 1882
Branches 318 318
=======================================
Hits 1742 1742
Misses 70 70
Partials 70 70 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Prepare for reusing the resource property definitions in the Kubernetes worker configuration.
teroyks
force-pushed
the
tero/refactor/execution-resources-yaml
branch
from
c137041
to
40e5238
Compare
ruksi
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs valohai/meta#275
Prepare for reusing the resource definition in the Kubernetes worker configuration to avoid copy/paste – at the moment, these two look identical.
If they later turn out to have different requirements, will then refactor to separate definitions.