Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling for dealing with dashed identifiers; port over common boolean evaluator #15

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

akx
Copy link
Member

@akx akx commented Jul 9, 2024

This PR adds Yet Another Rewriting Phase to deal with kebab-case identifier rewriting.

It also ports the "common boolean expression" evaluation from internal projects from leval so they can be shared.

@akx akx marked this pull request as ready for review July 10, 2024 08:06
@akx akx requested review from a team, hylje and tokkoro and removed request for a team July 10, 2024 08:06
Copy link
Contributor

@hylje hylje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good, I can't think of useful additions for now.

@hylje hylje merged commit feac5c0 into master Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants