Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6 - Make the compiler flags configurable #23

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix #6 - Make the compiler flags configurable #23

merged 1 commit into from
Dec 10, 2024

Conversation

joehu21
Copy link
Collaborator

@joehu21 joehu21 commented Dec 9, 2024

Add cmake variable CFLAGS and the option to pass custom compiler flags to cmake through command line. For example,

cmake .. -DCFLAGS="-O0 -Wno-unused-function"

@joehu21 joehu21 self-assigned this Dec 9, 2024
roshkhatri
roshkhatri approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joehu21 joehu21 merged commit 08e55ab into valkey-io:unstable Dec 10, 2024
3 checks passed
@joehu21 joehu21 deleted the issue6 branch December 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshkhatri roshkhatri roshkhatri approved these changes

Assignees

@joehu21 joehu21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joehu21 @roshkhatri