Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defrag: allow defrag to start during AOF loading #1420

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

JimB123
Copy link
Contributor

@JimB123 JimB123 commented Dec 10, 2024

Addresses #1393

Changes:

  • During AOF loading or long running script, this allows defrag to be initiated.
  • The AOF defrag test was corrected to eliminate the wait period and rely on non-timer invocations.
  • Logic for "overage" time in defrag was changed. It previously accumulated underage leading to large latencies in extreme tests having very high CPU percentage. After several simple stages were completed during infrequent blocked processing, a large cycle time would be experienced.

Addresses valkey-io#1393

During AOF loading or long running script, this allows defrag to be
initiated.

Signed-off-by: Jim Brunner <[email protected]>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (7e56488) to head (4688575).
Report is 6 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1420      +/-   ##
============================================
+ Coverage     70.86%   70.89%   +0.03%     
============================================
  Files           118      118              
  Lines         63612    63614       +2     
============================================
+ Hits          45079    45100      +21     
+ Misses        18533    18514      -19     
Files with missing lines Coverage Δ
src/defrag.c 91.25% <100.00%> (+1.66%) ⬆️

... and 15 files with indirect coverage changes

@ranshid ranshid self-requested a review December 11, 2024 16:20
Copy link
Member

@ranshid ranshid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we also discussed it offline. looks good.

@ranshid ranshid merged commit 0c8ad5c into valkey-io:unstable Dec 11, 2024
48 checks passed
@JimB123 JimB123 deleted the defrag-test branch December 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants