-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for src/module examples #1407
base: unstable
Are you sure you want to change the base?
Conversation
ac7ae7b
to
b6a286e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1407 +/- ##
============================================
+ Coverage 70.78% 70.85% +0.07%
============================================
Files 118 118
Lines 63561 63561
============================================
+ Hits 44994 45039 +45
+ Misses 18567 18522 -45 |
b6a286e
to
377c983
Compare
|
||
assert_match [r hello.leftpad td 4 0] "00td" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also do a module unload in the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to unload hellotype module, I found there is only VM_CreateDataType
function, why don't have any function to delete it? So that I can't unload hellotype module, because of ERR Error unloading module: the module exports one or more module-side data types can't unload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think u can skip unload hello_type module
324242e
to
19c8ddb
Compare
Signed-off-by: Codebells <[email protected]>
19c8ddb
to
aeb2109
Compare
We found there is coredump in hellodict #1395 , and there is no tcl test for these example modules.
check_commands_specs
to check command bycommand getkeys
.command getkeys
, except the following two kind of command.CMD_KEY_NOT_KEY
xread
.I recommand all module's tcl test to add this function to check command.