-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ci from main #2584
Merge ci from main #2584
Conversation
b3c1255
to
7ae99a6
Compare
7ae99a6
to
0eca0a7
Compare
e167018
to
bf1e3f7
Compare
As it was discussed with the team, this PR is too big and contains changes from multiple PRs. It is definetely recommended to split it into multiple PRs and iteratively increase the test coverage. Split PRSplit PR into multiple PRs. Some of them could be published and reviewed in parallel. Steps to do there.
Once step 5 completed we will have a full matrix CI green. Keep in mind that it still takes a lot of time and may suffer from unexpected CI or flakey test. Known issues as of now (at least ones I'm aware about):
Reorganize testing.Running all tests on all platform on all language/framework versions on all server versions on ... etc ... isn't a good approach. Adding a small 5 sec test increases overall CI duration for few minutes. Adding a new server version will add few hours there.
Proposal:
Following that proposal, full matrix tests won't run longer than an hour. We will be able to run full testing job on all release branches every night for all clients. It is not too late to do this. |
* Update README.md Signed-off-by: Avi Fenesh <[email protected]> * Update README.md - lint fix Signed-off-by: Avi Fenesh <[email protected]> * Update README.md ling Signed-off-by: Avi Fenesh <[email protected]> * Update node/README.md Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Avi Fenesh <[email protected]> --------- Signed-off-by: Avi Fenesh <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <[email protected]> * Fix mypy failing (valkey-io#2453) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> * Python: adds JSON.ARRLEN command (valkey-io#2403) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Co-authored-by: Shoham Elias <[email protected]>
* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <[email protected]> * Fix mypy failing (valkey-io#2453) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> * Python: adds JSON.ARRLEN command (valkey-io#2403) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Co-authored-by: Shoham Elias <[email protected]>
* CI - Minimal and full CI matrix impl Signed-off-by: avifenesh <[email protected]> * Fix mypy failing (valkey-io#2453) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> * Python: adds JSON.ARRLEN command (valkey-io#2403) --------- Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Shoham Elias <[email protected]> Co-authored-by: Shoham Elias <[email protected]>
) * Refactor tests to use async cleanup and improve error handling Signed-off-by: avifenesh <[email protected]> * Enhance Jest configuration and add test setup file; update build scripts and dependencies Signed-off-by: avifenesh <[email protected]> * Update devDependencies in package.json for hybrid-node-tests to latest versions Signed-off-by: avifenesh <[email protected]> * Enhance test utilities and command tests with improved wait logic and version checks Signed-off-by: avifenesh <[email protected]> * Refactor tests to assert expected replica reads are less than or equal to actual reads; update connection handling in utilities and allow unused imports in types Signed-off-by: avifenesh <[email protected]> * Update dependencies and enhance PyO3 bindings; add new features and improve type handling Signed-off-by: avifenesh <[email protected]> * Update GitHub workflows: enhance linting configurations, adjust engine version requirements, and remove obsolete Redis installation workflow Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
bf1e3f7
to
b004282
Compare
@Yury-Fridlyand |
Signed-off-by: avifenesh <[email protected]>
c16a373
to
31303a4
Compare
7236ee1
to
f2f7abf
Compare
Signed-off-by: Avi Fenesh <[email protected]>
f2f7abf
to
3fd210f
Compare
Issue: #2548
This pull request introduces significant improvements to the CI/CD workflow documentation and configuration. The key changes include a comprehensive guide to the CI/CD workflow, updates to the build and engine matrices, and enhancements to the workflow templates. These changes aim to streamline the testing process and ensure consistent execution across different environments and languages.
Documentation Enhancements:
.github/DEVELOPER.md
, covering workflow triggers, test coverage, language-specific workflows, shared components, and dynamic matrix generation.Configuration Updates:
build-matrix.json
to include new fields for specifying languages and added support for Amazon Linux. [1] [2]engine-matrix.json
to include new engine versions and types, ensuring specific versions are always tested.supported-languages-versions.json
to define supported language versions and always-run versions for various languages.Workflow Template Improvements:
create-test-matrices/action.yml
to dynamically generate matrices based on inputs, optimizing the CI/CD process.csharp.yml
to utilize the new dynamic matrices and added support for workflow dispatch inputs. [1] [2]Minor Adjustments:
build-node-wrapper/action.yml
andbuild-python-wrapper/action.yml
by adjusting the npm install process and making the engine version input optional. [1] [2]Checklist
Before submitting the PR make sure the following are checked: