From 8a717f6e38dea7fa60387e0005dbace0732a5d9d Mon Sep 17 00:00:00 2001 From: avifenesh Date: Fri, 25 Oct 2024 17:33:55 +0000 Subject: [PATCH] fixes round Signed-off-by: avifenesh --- .github/workflows/create-test-matrices/action.yml | 4 ++++ .github/workflows/lint-rust/action.yml | 1 - .github/workflows/nightly.yml | 4 ++-- .github/workflows/npm-cd.yml | 2 +- node/tests/GlideClient.test.ts | 8 +++----- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/create-test-matrices/action.yml b/.github/workflows/create-test-matrices/action.yml index 1cb49d92e3..6d65d9d06b 100644 --- a/.github/workflows/create-test-matrices/action.yml +++ b/.github/workflows/create-test-matrices/action.yml @@ -13,6 +13,10 @@ inputs: description: "Run the full matrix" required: true type: boolean + containers: + description: "Run in containers" + required: true + type: boolean outputs: engine-matrix-output: diff --git a/.github/workflows/lint-rust/action.yml b/.github/workflows/lint-rust/action.yml index d01ea92575..aa8c433660 100644 --- a/.github/workflows/lint-rust/action.yml +++ b/.github/workflows/lint-rust/action.yml @@ -12,7 +12,6 @@ inputs: runs: using: "composite" - steps: - uses: actions/checkout@v4 with: diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 1c38a18f5a..21838c1366 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -34,7 +34,7 @@ on: default: false schedule: # running tests by cron is disabled on forks by the condition defined for each job - - cron: "0 3 * * *" # Runs at 03:00 (3 AM) UTC every day + - cron: "0 3 * * *" # Runs at 03:00 (3 AM) UTC every day concurrency: group: nightly-${{ github.head_ref || github.ref }}-${{ toJson(inputs) }} @@ -84,7 +84,7 @@ jobs: run-full-tests-for-go: # Go deactivated in cron, uncomment condition to activate #if: (github.repository_owner == 'valkey-io' && github.event_name == 'schedule') || (github.event_name == 'workflow_dispatch' && inputs.go == true) - if: (github.event_name == 'workflow_dispatch' && inputs.go == true) + if: (github.event_name == 'workflow_dispatch' && inputs.go == true) || (github.repository_owner == 'valkey-io' && github.event_name == 'schedule') uses: ./.github/workflows/go.yml name: Run CI for go client secrets: inherit diff --git a/.github/workflows/npm-cd.yml b/.github/workflows/npm-cd.yml index b3809e7f67..6fba0f052e 100644 --- a/.github/workflows/npm-cd.yml +++ b/.github/workflows/npm-cd.yml @@ -23,7 +23,7 @@ on: required: true concurrency: - group: npm-${{ github.head_ref || github.ref }} + group: node-${{ github.head_ref || github.ref }}-${{ toJson(inputs) }} cancel-in-progress: true permissions: diff --git a/node/tests/GlideClient.test.ts b/node/tests/GlideClient.test.ts index daf51bdbd2..8fb0efc55a 100644 --- a/node/tests/GlideClient.test.ts +++ b/node/tests/GlideClient.test.ts @@ -140,11 +140,9 @@ describe("GlideClient", () => { "check that blocking commands returns never timeout_%p", async (protocol) => { client = await GlideClient.createClient( - getClientConfigurationOption( - cluster.getAddresses(), - protocol, - { requestTimeout: 300 }, - ), + getClientConfigurationOption(cluster.getAddresses(), protocol, { + requestTimeout: 300, + }), ); const promiseList = [