Skip to content

Commit

Permalink
tmp check
Browse files Browse the repository at this point in the history
  • Loading branch information
barshaul committed Jun 13, 2024
1 parent 167503e commit 0d51f71
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/install-valkey/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ runs:
echo "Installing valkey ${{ inputs.valkey-version }}"
git clone https://github.com/valkey-io/valkey.git
cd valkey
git checkout ${{ inputs.valkey-version }}ד
git checkout ${{ inputs.valkey-version }}
make
sudo make install
Expand Down
5 changes: 4 additions & 1 deletion node/tests/SharedTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export async function checkIfServerVersionLessThan(
version[1].toString() +
"." +
version[2].toString();
console.log("recieved version to compare: " + versionToCompare + ", min version = " + minVersion);

return versionToCompare < minVersion;
}

Expand Down Expand Up @@ -3096,7 +3098,8 @@ export function runBaseTests<Context>(config: {
await checkIfServerVersionLessThan("7.0.0");
const versionLessThan72 =
await checkIfServerVersionLessThan("7.2.0");

console.log("versionLessThan7="+versionLessThan7);
console.log("versionLessThan72="+versionLessThan72);
expect(await client.object_encoding(non_existing_key)).toEqual(
null,
);
Expand Down

0 comments on commit 0d51f71

Please sign in to comment.