Add support for SwiftPM resources via Swift 5.3 #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also this WWDC 2020 session: https://developer.apple.com/videos/play/wwdc2020/10169 Or read the related proposal: https://github.com/apple/swift-evolution/blob/master/proposals/0271-package-manager-resources.md Note that I have only made this compatible when used with SwiftPM. Integration via other dependency managers might be broken.
|
This was 7 days ago. Any plan to merge this ? @vadymmarkov :) |
|
Hi @Jeehut and thanks for your PR! Yes, we definitely want to have proper SPM support, but I think the library should work with other dependency managers because I'm pretty sure it's still being used via CocoaPods or Carthage. |
|
@vadymmarkov Any chance on getting this PR adjusted so it can be merged? |
|
@LordZardeck It was already done in #141. I think we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also this WWDC 2020 session: https://developer.apple.com/videos/play/wwdc2020/10169
Or read the related proposal: https://github.com/apple/swift-evolution/blob/master/proposals/0271-package-manager-resources.md
Note that I have only made this compatible when used with SwiftPM. Integration via other dependency managers might be broken.
Fixes #129.
To use this branch before it's merged, use this in your
Package.swift: