Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we split up en.json into separate files? #118

Open
dunyakirkali opened this issue May 9, 2019 · 2 comments
Open

Should we split up en.json into separate files? #118

dunyakirkali opened this issue May 9, 2019 · 2 comments

Comments

@dunyakirkali
Copy link
Contributor

The current structure (a single en.json file) makes it difficult to contribute to this repository.

When there is more than 1 PR pending, once the first one gets merged it always creates merge-conflicts for the one after
@vadymmarkov
Copy link
Owner

That's true, but I'm afraid it will make the parsing logic more complicated. Also, if we do it for en.json file it means we should probably do it for other locales, which could also be a problem.

@dunyakirkali
Copy link
Contributor Author

True that!
I’ll try to create something as a POC and discuss with u further how we can tackle the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dunyakirkali @vadymmarkov