Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-cli): building in ci #201

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(rln-cli): building in ci #201

merged 1 commit into from
Aug 9, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 9, 2023

Due to #199, rln-cli needed to be updated as well.

@rymnc rymnc added this to the Release v0.4.0 milestone Aug 9, 2023
@rymnc rymnc added the track:rln RLN Track - (Secure Messaging/Applied ZK), relay and applications label Aug 9, 2023
@rymnc rymnc self-assigned this Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Benchmark for 36e5a75

Click to view benchmark
Test Base PR %
FullMerkleTree::delete 1210.9±1.70ns 1215.2±1.67ns +0.36%
FullMerkleTree::get 0.1±0.00ns 0.1±0.00ns 0.00%
FullMerkleTree::override_range 3.1±0.00µs 3.1±0.00µs 0.00%
FullMerkleTree::set 1228.9±2.06ns 1213.2±1.61ns -1.28%
OptimalMerkleTree::compute_root 1392.9±1.84ns 1394.3±1.79ns +0.10%
OptimalMerkleTree::delete 1388.6±8.90ns 1382.4±1.27ns -0.45%
OptimalMerkleTree::get 30.6±0.73ns 30.4±0.06ns -0.65%
OptimalMerkleTree::override_range 7.0±0.01µs 7.0±0.01µs 0.00%
OptimalMerkleTree::set 1383.5±11.42ns 1374.2±1.62ns -0.67%

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Benchmark for 36e5a75

Click to view benchmark
Test Base PR %
Pmtree::compute_root 2.0±0.00ns 2.0±0.00ns 0.00%
Pmtree::get 469.0±0.35ns 469.5±0.36ns +0.11%
Pmtree::override_range 168.4±5.48µs 174.0±14.43µs +3.33%
Pmtree::set 71.9±0.05µs 69.3±0.05µs -3.62%
Pmtree:delete 69.9±0.05µs 69.5±0.12µs -0.57%

tyshko-rostyslav
tyshko-rostyslav approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@tyshko-rostyslav tyshko-rostyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now as a stopgap

@rymnc rymnc merged commit 7110e00 into master Aug 9, 2023
17 checks passed
@rymnc rymnc deleted the fix-rln-cli-compilation branch August 9, 2023 09:05
@tyshko-rostyslav tyshko-rostyslav mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyshko-rostyslav tyshko-rostyslav tyshko-rostyslav approved these changes

Assignees

@rymnc rymnc

Labels
track:rln RLN Track - (Secure Messaging/Applied ZK), relay and applications
Projects
Vac Research
Status: Done
Milestone
Release v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rymnc @tyshko-rostyslav