Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dynamically import atmosphere.js for SW context #2901

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

krissvaa
Copy link
Contributor

Fixes #2867

@krissvaa krissvaa force-pushed the fix/sw-context-dynamic-import branch from 5c613c4 to 33b8cc7 Compare November 13, 2024 14:06
Env should be optional for other frameworks
Fixes #2867
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.88%. Comparing base (84f99a2) to head (c8609ae).

Files with missing lines Patch % Lines
packages/ts/frontend/src/FluxConnection.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2901       +/-   ##
===========================================
- Coverage   92.79%   78.88%   -13.91%     
===========================================
  Files          84       83        -1     
  Lines        3149     3083       -66     
  Branches      759      743       -16     
===========================================
- Hits         2922     2432      -490     
- Misses        175      615      +440     
+ Partials       52       36       -16     
Flag Coverage Δ
unittests 78.88% <60.00%> (-13.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/ts/frontend/src/vite-env.d.ts Outdated Show resolved Hide resolved
packages/ts/frontend/src/FluxConnection.ts Outdated Show resolved Hide resolved
@Lodin Lodin requested a review from platosha November 25, 2024 10:54
Base automatically changed from fix/sw-context-access to main November 25, 2024 14:49
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA endpoint errors while called from SW
3 participants