-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow dynamically import atmosphere.js for SW context #2901
base: main
Are you sure you want to change the base?
Conversation
f5f6170
to
cf3a028
Compare
5c613c4
to
33b8cc7
Compare
Env should be optional for other frameworks Fixes #2867
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
===========================================
- Coverage 92.79% 78.88% -13.91%
===========================================
Files 84 83 -1
Lines 3149 3083 -66
Branches 759 743 -16
===========================================
- Hits 2922 2432 -490
- Misses 175 615 +440
+ Partials 52 36 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Fixes #2867