We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello!
Consider a tag list like this:
git tag --list v0.7 v0.8 v1.0 v1.0.5 v1.1.0-rc1 v1.1.1-hotfix
In order to match these tags, I've modified .gitchangelog.rc with
.gitchangelog.rc
tag_filter_regexp = r'^v[0-9]+\.[0-9]+(\.[0-9]+)?(\-(hotfix|rc\d+))?$'
Which I tested in https://regex101.com/r/npTVQv/3
After running gitchangelog ^v0.7 HEAD I get
gitchangelog ^v0.7 HEAD
%%unreleased_version%% ---------------------- New ~~~ *stuff* v1.1.0-rc1 (2019-05-06) ----------------------- *stuff*
Notice it's not picking v1.1.1-hotfix. However, if I change the last regex group to (\-(hotfix))? (removing rc\d+ from the or), I get
v1.1.1-hotfix
(\-(hotfix))?
rc\d+
or
%%unreleased_version%% ---------------------- New ~~~ *stuff* v1.1.1-hotfix (2019-05-06) -------------------------- *stuff*
The only thing that may be related is that both tags are from the same date, and gitchangelog is aggregating them using the first (i.e. oldest) match.
gitchangelog
This is happening before re.match in https://github.com/vaab/gitchangelog/blob/master/src/gitchangelog/gitchangelog.py#L1551, considering
re.match
In [4]: tags Out[4]: ['v0.7', 'v0.8', 'v1.0', 'v1.0.5', 'v1.1.0-rc1', 'v1.1.1-hotfix'] In [7]: for tag in tags: ...: if re.match(r'^v[0-9]+\.[0-9]+(\.[0-9]+)?(\-(rc\d+|hotfix))?$', tag): ...: print(tag) ...: v0.7 v0.8 v1.0 v1.0.5 v1.1.0-rc1 v1.1.1-hotfix
I'd appreciate if you could look into this.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello!
Consider a tag list like this:
In order to match these tags, I've modified
.gitchangelog.rc
withWhich I tested in https://regex101.com/r/npTVQv/3
After running
gitchangelog ^v0.7 HEAD
I getNotice it's not picking
v1.1.1-hotfix
. However, if I change the last regex group to(\-(hotfix))?
(removingrc\d+
from theor
), I getThe only thing that may be related is that both tags are from the same date, and
gitchangelog
is aggregating them using the first (i.e. oldest) match.This is happening before
re.match
in https://github.com/vaab/gitchangelog/blob/master/src/gitchangelog/gitchangelog.py#L1551, consideringI'd appreciate if you could look into this.
The text was updated successfully, but these errors were encountered: