From 31c8523f7d1065760e3104eff62b2ed82b60fc18 Mon Sep 17 00:00:00 2001 From: liranbg Date: Thu, 25 Jul 2024 17:06:59 +0300 Subject: [PATCH] initial --- stable/mlrun/Chart.yaml | 2 +- stable/mlrun/templates/db-configmap.yaml | 3 +- stable/mlrun/values.yaml | 120 +++++++++++++---------- 3 files changed, 70 insertions(+), 55 deletions(-) diff --git a/stable/mlrun/Chart.yaml b/stable/mlrun/Chart.yaml index dc714997a..bb7a00844 100644 --- a/stable/mlrun/Chart.yaml +++ b/stable/mlrun/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: mlrun -version: 0.9.26 +version: 0.9.27 appVersion: 1.6.4 description: Machine Learning automation and tracking sources: diff --git a/stable/mlrun/templates/db-configmap.yaml b/stable/mlrun/templates/db-configmap.yaml index 124fdc67d..b559de51a 100644 --- a/stable/mlrun/templates/db-configmap.yaml +++ b/stable/mlrun/templates/db-configmap.yaml @@ -43,12 +43,13 @@ data: INIT_SCRIPT="/etc/config/mysql/init-scripts/enable-root-remote-access.sql" echo "Starting MySQL ..." - + # TODO: review the innodb flags, they might not be needed anymore mysqld \ --user={{- include "mlrun.db.DBRunUser" . }} \ --sql_mode="" \ --init-file=$INIT_SCRIPT \ + --binlog-expire-logs-seconds={{- .Values.db.dbConfiguration.binlogExpireLogsSeconds }} \ --max-connections={{- .Values.db.dbConfiguration.maxConnections }} \ --innodb-adaptive-hash-index={{- .Values.db.dbConfiguration.innodb.adaptiveHashIndex }} \ --innodb-read-io-threads={{- .Values.db.dbConfiguration.innodb.readIOThreads }} \ diff --git a/stable/mlrun/values.yaml b/stable/mlrun/values.yaml index ac6c1adad..09bbfa539 100644 --- a/stable/mlrun/values.yaml +++ b/stable/mlrun/values.yaml @@ -28,7 +28,7 @@ api: ingress: enabled: false - annotations: { } + annotations: {} # kubernetes.io/ingress.class: nginx # kubernetes.io/tls-acme: "true" hosts: @@ -36,7 +36,7 @@ api: paths: - pathType: ImplementationSpecific path: / - tls: [ ] + tls: [] # - secretName: chart-example-tls # hosts: # - chart-example.local @@ -47,7 +47,7 @@ api: # Setting the affinity here has precedence over api.affinity # Note that by default we're assigning affinity to make the chief/worker pods to run on different nodes, if you're # overriding the affinity it's your responsibility to keep applying this behavior - affinity: { } + affinity: {} worker: fullnameOverride: @@ -60,7 +60,7 @@ api: # Setting the affinity here has precedence over api.affinity # Note that by default we're assigning affinity to make the chief/worker pods to run on different nodes, if you're # overriding the affinity it's your responsibility to keep applying this behavior - affinity: { } + affinity: {} image: repository: mlrun/mlrun-api @@ -94,24 +94,25 @@ api: # Extra env variables - passed as is to the api pod env section therefore can be used to any kind of env var extraEnv: [] -# - name: simple_env_var -# value: env_var_value -# - name: env_var_from_secret -# valueFrom: -# secretKeyRef: -# name: some_secret_name -# key: secret_key + # - name: simple_env_var + # value: env_var_value + # - name: env_var_from_secret + # valueFrom: + # secretKeyRef: + # name: some_secret_name + # key: secret_key # Extra env variables - each key value is creating a simple env var in the pod - unlike extraEnv, here env var with # numeric values can be passed extraEnvKeyValue: {} -# env_var_key: env_var_value -# env_var_key_2: env_var_value_2 + # env_var_key: env_var_value + # env_var_key_2: env_var_value_2 # envFrom can be used to pass configmaps or secrets as environment envFrom: [] - resources: {} + resources: + {} # limits: # cpu: 100m # memory: 128Mi @@ -143,7 +144,8 @@ api: podSecurityContext: {} # runAsUser: 1000 - securityContext: {} + securityContext: + {} # capabilities: # drop: # - ALL @@ -185,9 +187,9 @@ api: # persistentVolumeClaim: # claimName: mlrun-api-pvc - # Defines additional volume mounts from existing persistent volume claims. - extraPersistentVolumeMounts: [] + extraPersistentVolumeMounts: + [] # - name: extra-volume # mountPath: /mnt/volume # subPath: /sub/path @@ -208,25 +210,25 @@ api: fullnameOverride: config: {} -# services: -# acmecorp: -# url: https://example.com/control-plane-api/v1 -# response_header_timeout_seconds: 5 -# credentials: -# bearer: -# token: "bGFza2RqZmxha3NkamZsa2Fqc2Rsa2ZqYWtsc2RqZmtramRmYWxkc2tm" -# -# bundles: -# authz: -# service: acmecorp -# resource: bundles/http/example/authz.tar.gz -# persist: true -# polling: -# min_delay_seconds: 60 -# max_delay_seconds: 120 -# signing: -# keyid: global_key -# scope: write + # services: + # acmecorp: + # url: https://example.com/control-plane-api/v1 + # response_header_timeout_seconds: 5 + # credentials: + # bearer: + # token: "bGFza2RqZmxha3NkamZsa2Fqc2Rsa2ZqYWtsc2RqZmtramRmYWxkc2tm" + # + # bundles: + # authz: + # service: acmecorp + # resource: bundles/http/example/authz.tar.gz + # persist: true + # polling: + # min_delay_seconds: 60 + # max_delay_seconds: 120 + # signing: + # keyid: global_key + # scope: write logLevel: info logFormat: json @@ -238,14 +240,15 @@ api: pullSecrets: [] resources: -# requests: -# cpu: 100m -# memory: 10Mi -# limits: -# cpu: 3 -# memory: 200Mi - - securityContext: {} + # requests: + # cpu: 100m + # memory: 10Mi + # limits: + # cpu: 3 + # memory: 200Mi + + securityContext: + {} # capabilities: # drop: # - ALL @@ -313,8 +316,8 @@ api: extraEnvKeyValue: {} envFrom: - - configMapRef: - name: mlrun-log-collector-config + - configMapRef: + name: mlrun-log-collector-config securityContext: {} @@ -360,7 +363,8 @@ db: # envFrom can be used to pass configmaps or secrets as environment envFrom: [] - resources: {} + resources: + {} # limits: # cpu: 100m # memory: 128Mi @@ -388,7 +392,8 @@ db: podSecurityContext: runAsUser: 1001 - securityContext: {} + securityContext: + {} # capabilities: # drop: # - ALL @@ -420,7 +425,8 @@ db: # claimName: mlrun-db-pvc # Defines additional volume mounts from existing persistent volume claims. - extraPersistentVolumeMounts: [] + extraPersistentVolumeMounts: + [] # - name: extra-volume # mountPath: /mnt/volume # subPath: /sub/path @@ -428,7 +434,6 @@ db: # existingClaim: volume-claim exporter: - enabled: false name: db-exporter @@ -450,7 +455,8 @@ db: externalPort: 9104 internalPort: 9104 - collectors: {} + collectors: + {} # auto_increment.columns: false # binlog_size: false # engine_innodb_status: false @@ -494,6 +500,12 @@ db: # SUPER is a MySQL privilege that grants admin rights to the user. maxConnections: 512 + # set to 1 day + # https://dev.mysql.com/doc/refman/8.4/en/replication-options-binary-log.html#sysvar_binlog_expire_logs_seconds + # binlogs are useful for replication, backup, and point-in-time recovery + # we dont use mysql replication, so we can set it to 1 day + binlogExpireLogsSeconds: 86400 + innodb: # refer to https://github.com/v3io/helm-charts/pull/674 adaptiveHashIndex: 0 @@ -548,7 +560,8 @@ ui: # envFrom can be used to pass configmaps or secrets as environment envFrom: [] - resources: {} + resources: + {} # limits: # cpu: 100m # memory: 128Mi @@ -579,7 +592,8 @@ ui: # runAsUser: 101 # runAsGroup: 101 - securityContext: {} + securityContext: + {} # capabilities: # drop: # - ALL