Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty column names & duplicate column names #65

Open
tebeka opened this issue Oct 25, 2018 · 1 comment
Open

Support empty column names & duplicate column names #65

tebeka opened this issue Oct 25, 2018 · 1 comment
Assignees

Comments

@tebeka
Copy link
Contributor

tebeka commented Oct 25, 2018

We need to decide what to do with empty column names.

Looking at pandas:

  • read_csv will automatically assign names to columns if it's empty.
  • If there's a duplicate column names, and you try to get it - pandas will return a column (probably the first) that matches this name
@tebeka tebeka self-assigned this Oct 25, 2018
@tebeka
Copy link
Contributor Author

tebeka commented Oct 25, 2018

IMO the simple solution is to disallow column names and duplicate names. This will make things much simpler for us. This will move the logic of what to do with empty column names in the clients and the backends.

  • In Python we can check at the client level that the DataFrame comply
  • In Go NewFrame and friends can check it.

@yaronha - Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant