Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown isn't rendered correctly #43

Open
XenGi opened this issue Mar 21, 2017 · 5 comments
Open

markdown isn't rendered correctly #43

XenGi opened this issue Mar 21, 2017 · 5 comments

Comments

@XenGi
Copy link

XenGi commented Mar 21, 2017

As seen in the compaign: https://beta.yeahletsdothat.com/yeah/e88CZpTqbc75e8EB/

Markdown seems to be rendered with any css theme. So it's pretty hard to read tables.

@uwekamper
Copy link
Owner

uwekamper commented Mar 23, 2017

Tables are rendered correctly to valid HTML - but the < table >-Tag is missing the class="table" attribute that makes a table show up nicely when using bootstrap.

@XenGi
Copy link
Author

XenGi commented Mar 23, 2017

So it's fixed now?

@uwekamper
Copy link
Owner

Fixed in 457599c . needs testing

@XenGi
Copy link
Author

XenGi commented Mar 23, 2017

Seems like you're writing your own markdown generator. Isn't that a bit pointless? You could just use one that already exists. Like the one for github flavored markdown. Just put a CSS file on top and your done. You can even add custom markdown if you want. I mean the ones you added in yldt (youtube, etc) are already supported, so even that would be easier. It's the markdown standard that everybody uses anyway, so why reinvent the wheel?

https://py-gfm.readthedocs.io/en/latest/

And if you still want to do some fancy stuff on top, just write a markdown extension for the python markdown module.

Btw, it still doesn't work in production. Tables are still rendered without the class.

@uwekamper
Copy link
Owner

sigh The Markdown generator is http://mistune.readthedocs.io/en/latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants