Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide watch/blacklist buttons when action has already been taken #144

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

AppeazeTheCheese
Copy link
Contributor

This is to prevent misclicks, and the weird behavior that sends "Action already taken" as a chat message when clicking on a "disabled" action.

@double-beep
Copy link
Member

Why not just disable them?

I'm not a fan of hiding them (though I can't remember why I made them clickable when action had already been taken).

@AppeazeTheCheese
Copy link
Contributor Author

AppeazeTheCheese commented Dec 3, 2023

@double-beep That's what I tried to do originally, but I found that disabling a link while keeping the tooltip is a bit of a challenge, and disabling links is generally discouraged anyway, so I went with this. Plus, there's already an indication of whether or not something is watched/blacklisted with the emotes on the right, so I personally don't really see the point in showing it twice. I was also considering making them buttons instead of links which may make this easier, if you would prefer that instead?

@double-beep double-beep merged commit b62d957 into userscripters:master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants