Skip to content

Commit

Permalink
Merge pull request #1136 from uselagoon/dep_python_38
Browse files Browse the repository at this point in the history
build: deprecate python-3.8
  • Loading branch information
tobybellwood authored Oct 16, 2024
2 parents eb3ecdc + eabb877 commit 5982d70
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 22 deletions.
12 changes: 0 additions & 12 deletions helpers/TESTING_base_images_dockercompose.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep php-8-2-prod
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep php-8-3-dev
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep php-8-3-prod
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep python-3-8
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep python-3-9
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep python-3-10
docker ps --filter label=com.docker.compose.project=all-images | grep Up | grep python-3-11
Expand Down Expand Up @@ -183,17 +182,6 @@ docker compose exec -T commons sh -c "curl -kL http://php-8-3-prod:9000" | grep
docker compose exec -T commons sh -c "curl -kL http://php-8-3-prod:9000" | grep "upload_max_filesize" | grep "1024M"
docker compose exec -T commons sh -c "curl -kL http://php-8-3-prod:9000" | grep "error_reporting" | grep "22519"

# python-3-8 should be version 3.8
docker compose exec -T python-3-8 sh -c "python -V" | grep "3.8"

# python-3-8 should have basic tools installed
docker compose exec -T python-3-8 sh -c "pip list --no-cache-dir" | grep "pip"
docker compose exec -T python-3-8 sh -c "pip list --no-cache-dir" | grep "setuptools"
docker compose exec -T python-3-8 sh -c "pip list --no-cache-dir" | grep "virtualenv" | grep "16.7.10"

# python-3-8 should be serving content
docker compose exec -T commons sh -c "curl python-3-8:3000/tmp/test" | grep "Python 3.8"

# python-3-9 should be version 3.9
docker compose exec -T python-3-9 sh -c "python -V" | grep "3.9"

Expand Down
10 changes: 0 additions & 10 deletions helpers/images-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,16 +140,6 @@ services:
exec php -S 0.0.0.0:9000
"] # runs a webserver with phpinfo output
python-3-8:
image: uselagoon/python-3.8:latest
ports:
- "3000"
<< : *default-user # uses the defined user from top
command: ["sh", "-c", "
python -V | xargs > tmp/test;
exec python -m http.server 3000
"]
python-3-9:
image: uselagoon/python-3.9:latest
ports:
Expand Down
3 changes: 3 additions & 0 deletions images/python/3.8.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ LABEL org.opencontainers.image.description="Python 3.8 image optimised for runni
LABEL org.opencontainers.image.title="uselagoon/python-3.8"
LABEL org.opencontainers.image.base.name="docker.io/python:3.8-alpine3.20"

LABEL sh.lagoon.image.deprecated.status="endoflife"
LABEL sh.lagoon.image.deprecated.suggested="docker.io/uselagoon/python-3.12"

ENV LAGOON=python

# Copy commons files
Expand Down

0 comments on commit 5982d70

Please sign in to comment.