Format documentation; switch to argparse #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embed example; fix line breaks.
guynich
reviewed
Oct 25, 2024
| @@ -182,9 +153,10 @@ This is an example of the Moonshine base model being used to generate live capti | |||
| (env_moonshine_demo) parallels@ubuntu-linux-2404:~$ | |||
| ``` | |||
|
|
|||
| For comparison this is the Faster-Whisper int8 base model on the same instance. | |||
| For comparison, this is the `faster-whisper` int8 base model on the same instance. | |||
There was a problem hiding this comment.
nit: the example is float32 precision (not int8): this is a copy of my error. I can fix this in the parent branch.
|
LGTM: one comment which I can resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
live_captions.py.live_captions.pynow usesargparseto parse command line arguments. This will make it easier to add more supported models in the future; it also handles printing of help info/supported arguments on the command line.