Skip to content

Commit

Permalink
Update btstack
Browse files Browse the repository at this point in the history
This is needed to be compatible with "new" pico-sdk versions.
See raspberrypi/pico-sdk#1553 and #1

Unfortunately this will break compatibility with older pico-sdk
versions.
  • Loading branch information
usedbytes committed Nov 20, 2023
1 parent 6e51165 commit 70302e2
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
22 changes: 22 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,25 @@ make
```

The `.uf2` file will be `build/src/picow_ds4.uf2`

# Known Issues

`pico-sdk` implements its own `btstack` makefile (see
`$PICO_SDK_PATH/src/rp2_common/pico_btstack/CMakeLists.txt`), which means a
particular `pico-sdk` version is only technically compatible with a single
`btstack` version. See https://github.com/raspberrypi/pico-sdk/issues/1553 and
#1.

If you run in to build issues which look related to `btstack`, it could be
because the version this project depends on has diverged from your version
of `pico-sdk` again.

This repo is known to build OK against `pico-sdk` version
`6a7db34ff63345a7badec79ebea3aaef1712f374` (tag: 1.5.1).

There's two good ways to fix this, which maybe I'll do one day:

1. Upstream a configurable `MAX_ATTRIBUTE_VALUE_SIZE` to `btstack`, so that the
`btstack` submodule could be removed here.
2. Change `btstack`+`pico-sdk` to put the make rules inside `btstack` instead,
so that there's no implicit dependency between the two.
2 changes: 1 addition & 1 deletion btstack
Submodule btstack updated 321 files

0 comments on commit 70302e2

Please sign in to comment.