Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Makefile #3540

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stupidly-logical
Copy link

Description

Added Makefile to ease local development. Issue: #3531

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

Hey @stupidly-logical !

It seems that the make functions are essentially wrappers around the existing npm commands. I’m curious about the added value here since all of these tasks can already be executed directly using the npm run syntax. Could you clarify the reasoning behind this approach?

@stupidly-logical
Copy link
Author

Hi @helloanoop . So one the reasons why I like Makefile is it gives me concise commands with a way to club multiple npm commands together. For example in this particular PR I have make build-all that clubs together

npm run build:graphql-docs
npm run build:bruno-query
npm run build:bruno-common

Similarly Makefile can have a very concise replacement of the longer npm run sandbox:bundle-libraries --workspace=packages/bruno-js

Now of course it might be subject to personal preference. Its a good to have thing if your npm scripts grow in length or you want to club them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants