-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forecasted Grants #2201
Comments
@caitlinwinner fyi that I scheduled a meeting next week to discuss this one with me, you, and Pari, but flagging for you here as well in case you have initial thoughts on the open questions listed above |
Next step on this issue is to add design mock-ups and update requirements on the issue accordingly |
acceptance criteria needs to be fleshed out and compared with #2066 |
@TylerHendrickson this one is ready for implementation details! |
FYI @caitlinwinner some outstanding questions/adjustments needed for the designs and requirements:
|
|
@ClaireValdivia regarding "For any new search, Forecasted should be defaulted to be checked" -> does this mean that we still only want to show posted grants on initial page load? We don't want to show forecasted grants when the table is first loaded, is this correct? |
@masimons good catch! i think it would make sense to have both posted and forecasted show for "all grants", but curious for thoughts on if this would impact the load time of the page significantly if there are more total grants to load? |
@ClaireValdivia Since we are paginating, the load time should be the same as it is now per page. There will just be more pages to click through, as there will be more grants. But as far as I can tell, there is currently a max of 50 records retrieved for the grants table per page. That being said, if we run into performance issues for whatever reason, we can def cross that bridge and choose to only show posted grants. |
awesome thank you! I'll adjust the requirements to reflect:
|
@ClaireValdivia regarding "If opp status = forecasted and Estimated Application Due Date is blank in grants.gov - then display "Not yet issued" in the Close Date column" - shall we display "Not yet issued" for any grant that has a blank posted date, not just forecasted grants? Or do we actively prefer for posted grants without a close date to not display anything? (I imagine that the happy path for posted grants is that they always have a non-blank close date, but just trying to consider consistency for the edge cases) |
@masimons ah, I think it's addressed in a different bullet in that section: "If close date is blank AND opp status = posted - then display "Not yet issued" in the Close Date column" - does that address your question? |
@ClaireValdivia yes! sorry - thanks for the quick response. I have a color-coded google doc to keep track of these specs, and I miscolored it! |
Regarding "if opp status = Posted, Archived, or Closed, and Close Date is anything other than a date or blank, display: "see details" in the Close Date column" - from what I'm seeing, I did notice a field
|
@masimons Hmm this may be a case of me not knowing where things pull from in the table currently. This is an example of a grant where the close date is not a date: https://staging.grants.usdr.dev/grants/103313 -- is the text in the close date field pulling from |
Hey @ClaireValdivia ! It looks like right now, on the grant details page, we are showing the Would we want to mirror this logic for the forecasted grants as well, on the grants detail page? Separately though, for the grants table, I'm not seeing any logic around displaying alternate text (like "See details") if there's no close date (I believe this is because we force a display date - 1/1/2100). So, regarding forecasted grants that don't have a close date, would we want to show "See details" if that grant has a non-blank |
@masimons Again thank you so much for catching these inconsistencies!! Part of the goal of this update is to be doing away with the forced display of "1/1/2100". Let's move forward with "Not Available" displaying on both the grant table and grant details page in any scenario where there is not a date or an explanation provided (i.e. regardless of opp status) Grants Table
Grant Details Page
|
@ClaireValdivia Thank you for talking this through with me! Ok, that all sounds great. And, just to make sure I also understand what to do in the case that there is a blank close date/estimated application due date, but a non-blank close date explanation, shall I display "See details" under the Close Date column of the table? Regardless of opp status? (In the grant details page, I will just display the full text of the close date explanation) |
Yes, that is correct, @masimons! |
Why is this issue important?
Partner request and key area where grant finder returns less results than grants.gov as we don't include Forecasted grants in results. This is important to partners because it can take a lot of time to build a team to apply for a grant and pull the application together, so having as much lead time as possible increases the chances of an applicant being able to apply and secure the grant.
Current State
No forecasted grants are ingested to grant finder and therefore are not included in search
Expected State
Issue 330 exists for ingest
Figma designs
Search Drawer
Results Table - General
Results Table - Open Date and Close Date
Note that this includes changes to more than the forecasted open/close dates, but we want to make the changes together to be consistent.
Grant Details Page
For any forecasted grants:
Implementation Plan
Currently WIP
Search Drawer:
SearchPanel.vue -> add forecasted option to opportunityStatusOptions
SearchPanel.vue -> defaultCriteria -> add forecasted option to opportunityStatuses
Results Table - General:
grants.js -> criteria.opportunityStatuses = ['forecasted', 'posted'];
GrantsTable.vue → formattedGrants -> status: titleize(grant.opportunity_status)
Relevant Code Snippets
No response
The text was updated successfully, but these errors were encountered: