Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error in select.go causes a nil pointer dereference #708

Open
schneekatze opened this issue Feb 12, 2024 · 0 comments
Open

Unhandled error in select.go causes a nil pointer dereference #708

schneekatze opened this issue Feb 12, 2024 · 0 comments

Comments

@schneekatze
Copy link

In github.com/upper/db/[email protected]/internal/sqlbuilder/select.go:428 a possible error is ignored.

func (sel *selector) statement() *exql.Statement {
	sq, _ := sel.build()
	return sq.statement()
}

If an error takes place, sq can be nil, resulting into a panic "runtime error: invalid memory address or nil pointer dereference".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schneekatze