Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed Savers #55

Open
gxander85 opened this issue Sep 4, 2020 · 6 comments
Open

Closed Savers #55

gxander85 opened this issue Sep 4, 2020 · 6 comments

Comments

@gxander85
Copy link

gxander85 commented Sep 4, 2020

Is there a way to obtain the details of Savers that have closed/deleted? They appear in the transactions under relationships. However it is only the account.data.id
Is there a way to get displayName and accountType into relationships?

When joining the two calls in Power BI or Parabola, I had to build my own reference table based on transactions description of Transfer to "x".
X being the name of the saver.

When the saver has been closed, they no longer appear under /accounts

I'm sure others here would find that useful too.

@d11wtq
Copy link
Contributor

d11wtq commented Sep 4, 2020

Closed savers is certainly something that has been considered. I think the fact you're getting the account info for transactions on closed Savers is an unexpected oversight in the data coming out of the API, but perhaps the best solution is just to provide the closed Saver. There may be some nuance around this, so we'll have to have a closer look into it 👀

@gxander85
Copy link
Author

gxander85 commented Sep 5, 2020 via email

@jradtilbrook
Copy link

There hasn't been movement on this for a while. Do you have any update on a timeframe for this?

@leeTimothy
Copy link

+1 know its a quality of life as we can still go off the account id but would be nice to have it rolled in

@gxander85
Copy link
Author

+1 on this still for me too

@markbrown4
Copy link
Contributor

Sorry for the tumbleweeds on this one.

You're right that only transactions on still open accounts are visible in the API, much like in the app.

The solution here would probably be to expose a new Saver relationship on transactions.
And add endpoints for returning deleted savers and their transactions.

/savers
/savers/:id/transactions

It's not planned at this stage, but can see how it'd be useful for the full history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants