Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: None for edge_ids argument for extended add_edges_from implementation #290

Open
2 of 3 tasks
alexbarev opened this issue Mar 28, 2023 · 3 comments
Open
2 of 3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@alexbarev
Copy link
Contributor

alexbarev commented Mar 28, 2023

Describe what you are looking for

AFAIK add_edges_from provide 2 interfaces.

First here
It requires source_ids, target_ids, and optionally edge_ids that could be set as None explicitly graph.add_edges_from([1, 2, 3], [2, 3, 4], None).

Second here
But here, if I try to omit third positional argument or pass None, the exception ValueError: Edge Ids Must Be Sequence occurs.

Example:

import ukv.umem as ukv

db = ukv.DataBase()
graph = db.main.graph

# works fine
graph.add_edges_from([1, 2, 3], [2, 3, 4], None)

# ValueError: Edge Ids Must Be Sequence
graph.add_edges_from([1, 2, 3], [2, 3, 4], None, weight=2)

Could you add support for None for latter interface, because it could be redundant for client to generate and maintain edges_ids.

Can you contribute to the implementation?

  • I can contribute

Is your feature request specific to a certain interface?

Official Python bindings

Contact Details

No response

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexbarev alexbarev added the enhancement New feature or request label Mar 28, 2023
@alexbarev alexbarev assigned alexbarev and davvard and unassigned alexbarev Mar 29, 2023
@ashvardanian
Copy link
Contributor

@davvard, what's the status on this one?

@davvard
Copy link
Contributor

davvard commented Apr 7, 2023

I'm waiting for edge ids generation in UKV cpp graph interface.

@davvard
Copy link
Contributor

davvard commented Jul 25, 2023

#398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants