Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named default import #180

Closed
mateenagy opened this issue Jul 10, 2023 · 2 comments
Closed

Named default import #180

mateenagy opened this issue Jul 10, 2023 · 2 comments

Comments

@mateenagy
Copy link
Contributor

mateenagy commented Jul 10, 2023

When I use named export like

export default useExampleStore;

the current check in findExports only looking only for deafult export in code. This prevent in unimport package for example to use useExampleStore instead of filename (exampleStore).

I already create a pull request for make it work and also what I did and why:
#179

Also run all the test with this modification and every test passed.

@mateenagy
Copy link
Contributor Author

Hi @pi0 !
Can you check on this issue if you have some free time? I want to implement some feature in my project which depends on this issue.

I don't know how relevant this issue, but I think if the findExport method extract the name of the export then named default exports should be use the name also and not the file name.

Thank you for your time and for your awesome work and have a nice day!

@pi0
Copy link
Member

pi0 commented Jan 11, 2024

With #179 new defaultName meta allows access to named export variable name

@pi0 pi0 closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants