-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add usage section #70
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================
==========================
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed docs. I have reviewed as per your comment and assume we need to write the extension while executing the script. Feel free to ignore comments if aren't relevant.
Thanks again π
README.md
Outdated
``` | ||
|
||
You're ready to publish your CLI app to npm! | ||
|
||
## Utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename it to API and add more stuff like what other "type" are available for commands and explain default & required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you refer to the args
object @jd-solanki from defineCommand
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes args
's type
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea! I will add a section about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
Maybe, I could add that positional arguments are required by default, not if there is a default value. |
related to #73 |
Love these updates! answers most of my questions I had. Merging this will help so many others. |
π Linked issue
fix partially #62
β Type of change
π Description
This PR add a usage section to the README.
π Checklist