Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of security scanning services #221

Conversation

CorruptComputer
Copy link
Contributor

@Bod9001 I went through and cleaned up this code and made the pieces of it more standard with how the other services are done. There are still some bits that should be refactored around, but they can wait I think.

I retested this, the scans seem to be working fine and I got the pop-up from the game making a request to the changelog api.

@Bod9001 Bod9001 merged commit 4102898 into unitystation:SecuritySystem Nov 23, 2023
5 of 6 checks passed
@CorruptComputer CorruptComputer deleted the SecuritySystem-suggested-changes branch November 23, 2023 10:58
corp-0 pushed a commit that referenced this pull request Nov 24, 2023
* Initial security

* White list jusst for a backup

* Most of the easy stuff

* Tweaking

* Dialogue box

* better dialogue

* try ccatch

* The first passsinng ssecuurity

* First working scan

* cleaning up

* To do is

* Moved some stuff into Interfaces

* File service

* ooops

* zero warnings

* Verssion bump

* Naming

* no Newtonsoft.Json

* codacy channges

* Passing Fix

* No eerrors

* version bump

* formattting?

* Formmattingg?

* ssplit

* more splitting and fix

* formatting

* changges

* weird code

* fix tthe errors

* spacing

* no gotos

* spacing

* Improvemennts

* Comment

* A puush

* debug

* win

* win to max

* remove

* config

* Works for windows

* mac? And Linux funcctionality

* Automatic run of pipe

* Cleaning up

* Requested changes

* spacing

* Assembly name

* some requested changes

* fixes

* Coda see changes

* cleaaning up

* moree cleaaninng

* cleaning cleaning ccleaaninng

* http's

* docs

* Whiteespace?

* whitespace  changes

* logs

* whyyyy

* fixes

* logErroors

* Whitespacee changes

* Linux fix

* log

* logs

* mac fix

* Moree / shennanigans

* Evenn more \

* yay mac is stupid

* .app

* AnyURL

* move to Installation path

* format

* warnings

* flatpack fix

* format

* try catch

* Cleanup of security scanning services (#221)

---------

Co-authored-by: Nickolas Gupton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants