Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to instructional website data #1002

Open
j-ro opened this issue Apr 16, 2014 · 11 comments
Open

Improvements to instructional website data #1002

j-ro opened this issue Apr 16, 2014 · 11 comments
Assignees
Labels

Comments

@j-ro
Copy link
Contributor

j-ro commented Apr 16, 2014

A few improvements on the instructions data...

First, would be nice to be able to hide members that are 100% working, to narrow down on unworking ones.

Would be also nice to have some counts/running totals, like 329 out of 518 working, based on the 100% badges.

@j-ro j-ro added the Other label Apr 16, 2014
@moizsyed
Copy link
Contributor

+1, would make everyones life a little easier

@ghost
Copy link

ghost commented Apr 16, 2014

+1

@akosednar
Copy link
Member

We should try accessing the svg elements as they load to determine the status.

@akosednar
Copy link
Member

@moizsyed and I have been discussing ideas on this:

akosednar: How I'm thinking of the functionality is add a selector to the table body and then using javascript do foreach of the tr>td>svg of the rows and set a class to it depending on if it's success or failed (from the svg data). Then we can hide/show based on that class

@moizsyed is also starting on this

@akosednar
Copy link
Member

A json endpoint is the better solution

@seanknox
Copy link

Yeah, I'm not sure how you could parse the badge img's to determine status. +1 to json

@Hainish
Copy link
Contributor

Hainish commented Apr 16, 2014

How it currently stands: every load of the congress-forms-test front page makes hundreds of requests and queries on congress-forms. A JSON endpoint may not reduce the number of queries for statuses, but it would drastically reduce the number of requests and open/closes to the DB server

@moizsyed
Copy link
Contributor

alright, someone please setup the json endpoint.. and then i will work on this patch

@moizsyed
Copy link
Contributor

Maybe we should take this on after we're at a good place for the time being with most of the forms being stable.

This will help us make the instruction page a little better identifying which forms are failing, so volunteers in the future can tackle them promptly.

@ahdinosaur
Copy link

+1

@mejackreed
Copy link
Contributor

Happy to work on this. API endpoint from https://github.com/EFForg/congress-forms/ no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants