Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2274 Benchmark User Guide #2566
base: main
Are you sure you want to change the base?
2274 Benchmark User Guide #2566
Changes from 25 commits
eedd305
215ecf6
e7c3a3b
99b6848
3648c29
63da003
f6876c2
d8b9232
f6a1ed8
07e298b
f1b36bb
ccb5586
e94ae2e
0a90ac5
e5e6746
0a17fb6
f9bca24
030a819
8e07d13
d3dcfab
e03961a
302eea0
e06c969
f82f54d
48c94a1
5217250
9492572
c0df4e0
ce2f673
afb5b46
36eb87d
3e48c5e
0ca08d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some details about what the state of each circuit is supposed to be? For example, the ideal output of a randomized benchmarking circuit is an identity.
GHZ and W circuits define a state. So, you could use some latex equations to show what the states are supposed to be etc.
We don't want to describe what the addition of noise will do to a circuit. the focus is on the details of the benchmarking circuit. All docstrings link a reference used to define a particular benchmarking circuit. You could use details from these refs if you don't know a lot about these circuits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also use
.final_state_vector()
to show the ideal circuit state, which is what we expect it to be.this will spit out the 1-D vector form of a 3 qubit GHZ state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can add this function to the example workflow at the top of the file instead of adding it explicitly inside every circuit, so every circuit's ideal circuit state can be seen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the section is about benchmarking, I believe we should show improvements with mitiq when compared to a noisy circuit without mitiq. But if you think otherwise, I can remove that part from the examples.
Also, since I have now added .final_state_vector(), shall I still go ahead and add the latex equations to show what the states are supposed to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus is on benchmarking circuits. Not benchmarking the performance of a QEM technique using mitiq.