New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return concrete error types like httpError, just return error #81

Open

oyvindhagberg opened this issue Jan 23, 2019 · 1 comment

Assignees

Labels

code quality good first issue

Contributor

oyvindhagberg commented Jan 23, 2019 •

edited

Loading

Here's an explanation from GopherCon 2016: Francesc Campoy - Understanding nil
And another explanation from the Go documentation

In this project, for example, see how *httpError can be mistaken for error here.

Here's a good example on how to make your own error types. Use type assertion to get the custom error type.

oyvindhagberg added the code quality label

oyvindhagberg added the good first issue label

Contributor Author

oyvindhagberg commented Nov 7, 2019

Her (og kanskje flere steder) er det: https://github.com/usit-gd/nivlheim/blob/f7b76621af03207a058db8e510608f99cbf8184e/server/service/api_hostlist.go#L332

mapemapemape self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment