Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The forecaster component should be located outside the docker directory #29

Open
ema-pe opened this issue Dec 2, 2024 · 0 comments
Open
Labels
forecaster Related to the forecaster component (dfaas-agent) refactoring

Comments

@ema-pe
Copy link
Collaborator

ema-pe commented Dec 2, 2024

The source code for the forecaster component is currently located in docker/forecaster. This is not a preferred location, as the docker directory should only contain code related to the generation of docker images (such as static files or dockerfiles). The forecaster should be in an independent directory under the project root, or under the dfaasagent directory.

Stefano Cattaneo, the original author of this module, said that he placed the forecaster component there because we could not run Docker with two independent context paths (files and forecaster), so he solved this problem by having a single context under the docker directory.

@ema-pe ema-pe added refactoring forecaster Related to the forecaster component (dfaas-agent) labels Dec 2, 2024
@ema-pe ema-pe changed the title The forecaster component should be located outside the `docker' directory The forecaster component should be located outside the docker directory Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forecaster Related to the forecaster component (dfaas-agent) refactoring
Projects
None yet
Development

No branches or pull requests

1 participant