Extend workload pools to include ingress firewall and ip allocations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsricardor
force-pushed
the
ingressfw_ipallocation
branch
from
8b85a58 to
5b526af
Compare
spjmurray
approved these changes
Oct 22, 2024
| @@ -256,6 +424,38 @@ components: | |||
| machine: | |||
| flavorId: c7568e2d-f9ab-453d-9a3a-51375f78426b | |||
| replicas: 3 | |||
| firewall: | |||
There was a problem hiding this comment.
Examples are obviously the best illustration to review 😸
Looks good so far. I'd have a word with Adam, the firewall rules may need a description to make the UI happier.
| publicIP: | ||
| description: Machine public IP address. | ||
| type: string | ||
| status: |
There was a problem hiding this comment.
You should reference https://github.com/unikorn-cloud/core/blob/main/pkg/openapi/common.spec.yaml#L90 here to keep things in sync.
| port: | ||
| $ref: '#/components/schemas/firewallRulePort' | ||
| cidr: | ||
| description: A list of CIDR blocks to allow, it might be any IPv4 or IPv6 in CIDR notation. |
There was a problem hiding this comment.
Surprise I've not done this yet, but we should probably have a type definition in core for an IPv4 CIDR with the required regular expression patter matcher too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends workload pools to include ingress firewall and IP allocations and add a status so users can discover the hostname and IP addresses of provisioned machines