Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderParameter image size adaptation methods are not always consistent #57

Open
sschoenborn opened this issue May 24, 2017 · 0 comments
Labels

Comments

@sschoenborn
Copy link
Contributor

RenderParameter has three methods to adapt to image size:

  • withImageSize: changes the sampling rate of the image, affects the resolution of the rendering -- works as intended
  • forImageSize: crops or enlarges view without changing the face's size. Does distort the face when the original aspect ratio is not square
  • fitToImageSize: should adapt the size of the image by scaling and padding to match the new size best without distorting the face. Distorts the face if the original aspect ratio is not square

The methods do not always work if the original image size is not square

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant