Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Button #15

Closed
Acovendesigns opened this issue Sep 28, 2020 · 6 comments
Closed

Download Button #15

Acovendesigns opened this issue Sep 28, 2020 · 6 comments

Comments

@Acovendesigns
Copy link

Would be really nice to have an optional free download button built into the grid.

@kontur
Copy link
Collaborator

kontur commented Sep 29, 2020

Thanks for the feature request.

I am actually refactoring the module a bit to allow better variable font instantiation, and as part of that I am thinking of adding a feature that would allow adding any referenced DOM node as part of the UI. Something like:

var custom = document.getElementById("mycustomelement")
options = {
  order: ["fontsize", "lineheight", custom, "tester"]
}

Do you think that would work for your use case? You could pass in a custom element for each instance that you have on the site like this and supply any custom DOM you'd like to have in that element inside the grid.

@kontur kontur added enhancement New feature or request nice to have labels Sep 29, 2020
@Acovendesigns
Copy link
Author

Acovendesigns commented Sep 29, 2020 via email

@Acovendesigns
Copy link
Author

Acovendesigns commented Sep 29, 2020 via email

@kontur
Copy link
Collaborator

kontur commented Sep 30, 2020

Cheers for the input, I've got something like that already noted in #12 — other things have priority, though.

@kontur
Copy link
Collaborator

kontur commented Sep 30, 2020

I think that would solve it, where were you thinking the HTML for the custom element would be stored?

I imagine this HTML being placed anywhere on the page. You specify the element, and it will be "extracted" from where it is and added to where you specify in the order inside the Fontsampler instance. Does that make sense?

@kontur
Copy link
Collaborator

kontur commented Nov 27, 2022

This is now released in 0.1.0.

@kontur kontur closed this as completed Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants