feat: Remove all usage of init() and global command objects #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 74.57% 75.48% +0.90%
==========================================
Files 15 15
Lines 704 726 +22
==========================================
+ Hits 525 548 +23
+ Misses 170 168 -2
- Partials 9 10 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
|
||
| func TestNewRootCommand(t *testing.T) { | ||
| // Mostly just ensure nothing errors out. | ||
| c := cmd.NewRootCommand() |
JoseAngel1196
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
init()is generally a bad practice. We don't like side effects. Same thing with global variables. This does away with both! At least as far as the commands themselves are concerned.This also makes our code ever so slightly more testable. Hopefully.