Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/modify funds contract attributes #184

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Add/modify funds contract attributes #184

merged 3 commits into from
Nov 3, 2024

Conversation

EmmanuelAR
Copy link
Collaborator

Pull Request

Changes description

Changes:
Fix type for name value and fix test
Add new attribute evidence_link and contact_handle with get and set methods.
Add test.

Current output

Captura de pantalla 2024-11-02 a la(s) 10 55 25 p  m

@EmmanuelAR
Changes:
67e6899 
Fix type for name value and fix test
Add new attibute evidence_link and contact_handle with get and set methods.
Add test.
@EmmanuelAR EmmanuelAR requested a review from adrianvrj November 3, 2024 04:55
adrianvrj
adrianvrj requested changes Nov 3, 2024
View reviewed changes
contracts/tests/test_fund.cairo Outdated Show resolved Hide resolved
contracts/src/fund.cairo Outdated Show resolved Hide resolved
@EmmanuelAR
Copy link
Collaborator Author

@adrianvrj ready, please review it again plese Sr

adrianvrj
adrianvrj approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work g

@adrianvrj adrianvrj merged commit 6a9d478 into undefinedorgcr:dev Nov 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Add/modify funds contract attributes
2 participants
@EmmanuelAR @adrianvrj