Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from polling to event monitoring in scan #7

Open
ulrikpedersen opened this issue Jul 5, 2023 · 1 comment
Open

Switch from polling to event monitoring in scan #7

ulrikpedersen opened this issue Jul 5, 2023 · 1 comment
Assignees
Labels
waiting Work paused

Comments

@ulrikpedersen
Copy link
Owner

The performance of the scan is currently tightly coupled to the polling loop that waits for the laser to pulse in the pulse_sync() function, when using the wait_for_value() function.

Performance could be improved by implementing an event-based solution using CA monitors. This is most likely what is implemented for Ophyd2, so this issue could be resolved in a couple of ways:

Either: investigate the current development state of Ophyd2 and evaluate if it is mature enough to be adopted for this experiment.
Or: re-implement wait_for_value() as an asynchronous function using a CA monitor.

@ulrikpedersen ulrikpedersen added this to the First CLF DAQ Team Demo milestone Jul 5, 2023
@8ryn 8ryn added the in progress Work on issue in progress label Jul 13, 2023
@8ryn
Copy link
Collaborator

8ryn commented Jul 14, 2023

Did some investigation into ophyd 2 and worked with a basic device.
Asked for suggestions on Nikea slack. Tom Cobb said that within ophyd 2 wait_for_value could be implemented within the trigger or read method of an ophyd 2 device. He queried whether there may be a way of keeping the wait_for_value within the plan rather than the device (which would likely be more straightforward for our purpose) and so we are awaiting feedback on that front.

@8ryn 8ryn added waiting Work paused and removed in progress Work on issue in progress labels Jul 14, 2023
@ulrikpedersen ulrikpedersen removed this from the First CLF DAQ Team Demo milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Work paused
Projects
None yet
Development

No branches or pull requests

2 participants