Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useMemo call to useLocalStorage so that the value returned only changes if store actually changes. #304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add useMemo call to useLocalStorage so that the value returned only changes if store actually changes. #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,10 +622,14 @@ export function useLocalStorage(key, initialValue) {
getLocalStorageServerSnapshot
);

const currentValue = React.useMemo(() => {
return store ? JSON.parse(store) : initialValue;
}, [store, initialValue]);

const setState = React.useCallback(
(v) => {
try {
const nextState = typeof v === "function" ? v(JSON.parse(store)) : v;
const nextState = typeof v === "function" ? v(currentValue) : v;

if (nextState === undefined || nextState === null) {
removeLocalStorageItem(key);
Expand All @@ -636,7 +640,7 @@ export function useLocalStorage(key, initialValue) {
console.warn(e);
}
},
[key, store]
[key, currentValue]
);

React.useEffect(() => {
Expand All @@ -648,7 +652,7 @@ export function useLocalStorage(key, initialValue) {
}
}, [key, initialValue]);

return [store ? JSON.parse(store) : initialValue, setState];
return [currentValue, setState];
}

export function useLockBodyScroll() {
Expand Down