Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the existence check of a task directory #24

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix the existence check of a task directory #24

wants to merge 2 commits into from

Conversation

luismafra
Copy link
Contributor

close #23

thiagomanel
thiagomanel requested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@thiagomanel thiagomanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a single question

src/main/java/saps/common/core/storage/swift/SwiftAPIClient.java
}
return false;
throws IOException {
String url = String.format(TASK_URL_PATTERN, swiftUrl, containerName, basePath, taskId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the listFiles implementation? could we removed it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still used in other methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagomanel thiagomanel thiagomanel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the existence check of a task directory in the Swift API
2 participants
@luismafra @thiagomanel