-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1281 migrate simulated and world camera topic names to consistent format #1297
Open
thadavale
wants to merge
21
commits into
master
Choose a base branch
from
1281-migrate-simulated-and-world-camera-topic-names-to-consistent-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1281 migrate simulated and world camera topic names to consistent format #1297
thadavale
wants to merge
21
commits into
master
from
1281-migrate-simulated-and-world-camera-topic-names-to-consistent-format
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, it's your friendly InvestiGator bot here! The docs preview for this PR is available at https://mil.ufl.edu/pr-docs/1297. Last updated at:
► c7bb70b8ce2f79e87a81aaec8307d4665938503c
► 2024-10-21 09:11 EDT Have a great day! Go gators! 🐊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was able to migrate the simulated camera topics to the real-world camera topics by remapping the old simulation-specific topic names onto the new real-life topic names inside NaviGator/mission_control/navigator_launch/launch/simulation.launch and NaviGator/mission_control/navigator_launch/launch/vrx/vrx_classifier.launch.
I also changed the simulation topic names to their real-life versions inside of all of the files they appeared in.
Screenshot or Video
Related Issues
- Closes #1281
Testing
Just launch Navigator using this template command for worlds inside NaviGator/simulation/navigator_gazebo/worlds.
roslaunch navigator_launch simulation.launch use_mil_world:=True world:= --screen
About This PR