Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to handle ConnectionClosedError #140

Merged
merged 3 commits into from
Oct 16, 2022
Merged

fix to handle ConnectionClosedError #140

merged 3 commits into from
Oct 16, 2022

Conversation

otariidae
Copy link

#130 に ConnectionClosedError のハンドリングをしなくなるデグレがあったのを修正

@otariidae otariidae requested a review from Azuki-bar October 16, 2022 11:37
Azuki-bar
Azuki-bar approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@Azuki-bar Azuki-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

frontend/videoCast/one_to_multiple_cast_skyway.py Show resolved Hide resolved
@otariidae otariidae mentioned this pull request Oct 16, 2022
Open
@otariidae otariidae merged commit 4aa2878 into main Oct 16, 2022
@otariidae otariidae deleted the connectionclosederror branch October 16, 2022 14:56
@github-actions github-actions bot mentioned this pull request Oct 16, 2022
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azuki-bar Azuki-bar Azuki-bar approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otariidae @Azuki-bar