Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeRaceData 廃止したい #95

Closed
Azuki-bar opened this issue Oct 4, 2022 · 1 comment · Fixed by #109
Closed

RangeRaceData 廃止したい #95

Azuki-bar opened this issue Oct 4, 2022 · 1 comment · Fixed by #109
Assignees
@Azuki-bar @hutinoatari
Labels
PB

Comments

@Azuki-bar
Copy link
Member

RanceRaceDataは出走日時を絞って取得するrpcである。

chofu-race-course/proto/spec/v1/userdata.proto

Line 117 in c79c8ad

rpc RangeRaceData(RangeRaceDataRequest) returns (RangeRaceDataResponse) {}

しかしHorseはフロントエンドで絞ることになっているために整合性が取れていない。

chofu-race-course/proto/spec/v1/userdata.proto

Line 49 in c79c8ad

rpc AllHorseData(AllHorseDataRequest) returns (AllHorseDataResponse) {}

#54

そのためRangeRaceDataを廃止して、AllRaceDataを追加したい。
@Azuki-bar Azuki-bar added the PB label Oct 4, 2022
@Azuki-bar Azuki-bar mentioned this issue Oct 4, 2022
Merged
@hutinoatari
Copy link
Member

廃止しましょう

@hutinoatari hutinoatari mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azuki-bar Azuki-bar

@hutinoatari hutinoatari

Labels
PB
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RangeRaceDataをAllRaceDataに変更 ueckoken/chofu-race-course
2 participants
@Azuki-bar @hutinoatari