Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork status #12

Open
jayvdb opened this issue Sep 23, 2021 · 3 comments
Open

Fork status #12

jayvdb opened this issue Sep 23, 2021 · 3 comments

Comments

@jayvdb
Copy link

jayvdb commented Sep 23, 2021

Is this a long lived fork? I've raised a few issues in the main repo , and intend to work on them, so could just as easily do them here as this project seems a bit more active.

The README "Installation" is wrong for this repo if it is to be a permanent fork.

It would be nice to try to submit the new rule back to https://github.com/appannie/eslint-plugin-gettext

@arski
Copy link
Collaborator

arski commented Sep 24, 2021

Hey @jayvdb this is actively maintained, but it looks like we've committed some changes that are kind of unique to our code - #1 and #2 which probably shouldn't be in the "main" version of this library 🤔

This new rule however is quite generic #6 and could be useful in the main repo. Would you like me to raise this PR into the appannie version? Or you can go ahead as well, I don't mind :)

@jayvdb
Copy link
Author

jayvdb commented Sep 30, 2021

It would be great if you could raise a PR for #6 upstream.

@jayvdb
Copy link
Author

jayvdb commented Oct 1, 2021

You may also be interested in helping with design of two features I've raised at https://github.com/appannie/eslint-plugin-gettext/issues , and I've done a hacking implementation of one of them which needs experienced eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants