Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update to highlight need for assertionConsumerService url to point to '/hub/acs' #8

Open
romyv opened this issue Dec 20, 2022 · 2 comments

Comments

@romyv
Copy link

romyv commented Dec 20, 2022

The '/hub/acs' URI is mentioned in the existing README page for the env.var. - but it also should be mentioned to be used in settings.json.

The current README points to python3-saml for "anything else" that is not mentioned on these pages.

The referenced python3-saml docs however show "/?acs" as the assertionConsumerService url value.

Configuring it as such in the current setup gives a 405 "Method not allowed" on a POST to "/?acs".

Running jupyterhub 1.5.1, with jupyterhub-saml-auth 0.3.2 on the-littlest-jupyterhub 0.1

The correct assertionConsumerService url in settings.json should be '/hub/acs' - in which case SAML auth works fine.

@romyv
Copy link
Author

romyv commented Dec 20, 2022

(alternatively: a uri rewrite from /acs to /hub/acs would be needed)

dafeliton added a commit that referenced this issue May 15, 2023
@dafeliton
Copy link
Contributor

Hello @romyv , thanks very much for the feedback. We've updated the README on a separate soon-to-be-merged branch to reflect your suggestion. Do our revisions accurately cover what you've mentioned here?

Please see this commit for more info.

RockfordMankiniUCSD added a commit that referenced this issue May 18, 2023
* added logout functionality

* added slo

* added slo

* Updated slo and added cache

* Working cache implementation

* Fixed basic test

* Refactored test

* Updated test

* Added comments & formatting

* implemented RedisCache

* modified client instantiation and added password

* formatted documents

* Updated

* Added vscode settings

* Added black

* Renamed to kwargs for clarity

* Refactored cache factory

* Reformatted

* Abstracting out acceptance tests

* Unit tests for redis cache

* Updated acceptance tests

* Updated docs

* Formatted

* Removed unused dependencies

* Refactored auth setup

* Removed proxy driver

* Updated readme

* Added docker workflow

* Testing new workflow

* Added extra action

* Fixed error

* Fixed syntax

* Added root install

* Fixed label

* Updated install process

* Fixed typo

* Explicitly using bash

* Fixed bash statement

* Updated build

* Optional install step for k8s-hub img

* Fixed typing

* Bumped version

* Added simple logout

* Renamed simple_logout

* Added status

* Added logging

* Fixed acceptance tests and formatted

* Formatted doc

* Reordered methods

* Added https override to authenticator

* updated docs

* Trigger rebuild

* Fix deprecation warning, attempt to resolve selenium error

* Try and fix timeout

* Test old driver selection method

* Temporarily ignore redis

* Add sleep to ensure that docker-compose calls have cleared

* Fix missing space

* Increase sleep, show docker compose verbosity

* Fix verbosity error

* Do not teardown docker compose...

* Add sleep before each WebDriverWait call

* Try multiple times

* Add missing import

* Use eager render, refresh page on fail

* 5 tries instead of 3; 20 second wait instead of 15

* Change to 10 tries, 45 seconds

* Fix firefox, ignore 3.8/3.7, ignore DS_Store

Adding firefox tests shortly

* Fix firefox typo

* Add delays

* Add firefox to github actions tests

* Set page load timeout

* Add additional info regarding /hub/acs

#8

* Add debug to timeoutexception

* Add driver.get retry

ConnectionReset error will be randomly thrown by driver.get()...

* Fix type error

* Manually merge #10

Re-enable 3.7,3.8 py tests

* Finalize branch

* Test Jupyterhub 4

* Wait for URL instead of waiting 10sec

* Remove driver.refresh() calls

* Replace refresh() with quit()

* Make delays longer

* Add set_page_load_timeout

* Switch back to refresh, disable firefox (for now)

* Do not call driver.refresh() if on firefox

* Disable firefox tests

* Test handlers.py changes

* Update handlers.py

* Update handlers.py

---------

Co-authored-by: Arjun Ghoshal <[email protected]>
Co-authored-by: wesuuu <[email protected]>
Co-authored-by: Naval Patel <[email protected]>
Co-authored-by: Dominic Feliton <[email protected]>
Co-authored-by: dafeliton <[email protected]>
Co-authored-by: RockfordMankiniUCSD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants