Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being able to extract the groups of the users from the SAML attributes #6

Open
kzgrzendek opened this issue Aug 3, 2022 · 2 comments
Open

Being able to extract the groups of the users from the SAML attributes #6

kzgrzendek opened this issue Aug 3, 2022 · 2 comments

Comments

@kzgrzendek
Copy link

Hello!

I would like to thank you for you simple yet elegant 'wrapper' around OneLogin's SAML library ; it(s working like a charm.

I would like to propose (and will submit a MR soon) a simple addition : being able to extract the groups the user is in from the SAML attributes.
That way, we'll be able to perform group-based auth from the SAML response, which in my case is very handy (I suppose it could be useful to others too?)
@wesuuu
Copy link
Contributor

wesuuu commented Aug 18, 2022

Hi @kzgrzendek ,

Sorry for the late reply. Yes, please do submit a pull request for that if you already implemented it

@dafeliton
Copy link
Contributor

Hello @kzgrzendek ,

Are you still interested in submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kzgrzendek @wesuuu @dafeliton